Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): Adjust testing matrix for php8.3 nightly builds #5589

Closed
wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (66c73c9) 24.45% compared to head (67fae93) 24.45%.
Report is 15 commits behind head on main.

Files Patch % Lines
src/components/Editor/Alarm/AlarmListItem.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5589   +/-   ##
=========================================
  Coverage     24.45%   24.45%           
  Complexity      418      418           
=========================================
  Files           243      243           
  Lines         10833    10833           
  Branches       1776     1776           
=========================================
  Hits           2649     2649           
  Misses         8184     8184           
Flag Coverage Δ
javascript 15.50% <0.00%> (ø)
php 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala self-requested a review November 30, 2023 10:39
.github/workflows/php-test.yml Outdated Show resolved Hide resolved
@miaulalala miaulalala force-pushed the update-main-target-versions branch from 6640cb5 to 4f38559 Compare December 4, 2023 15:00
@miaulalala miaulalala changed the title chore(CI): Adjust testing matrix for Nextcloud 28 on main chore(CI): Adjust testing matrix for php8.3 nightly builds Dec 4, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
@miaulalala miaulalala force-pushed the update-main-target-versions branch from c9e8bc6 to 67fae93 Compare December 21, 2023 15:21
@tcitworld
Copy link
Member

Do we need this at all anymore? Both master and stable28 are already compatible with 8.3.

@miaulalala miaulalala closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants